Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix $enable-css-grid → $enable-cssgrid in 'Customize > Options' #40818

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Docs: fix $enable-css-grid → $enable-cssgrid in 'Customize > Options' #40818

merged 3 commits into from
Oct 2, 2024

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Sep 12, 2024 •
edited
Loading

Description

Everything's the title, this PR fixes a typo in "Customize > Options": $enable-css-grid → $enable-cssgrid.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond force-pushed the main-jd-fix-typo-for-enable-cssgrid-sass-var branch from 9d05d45 to 87133f3 Compare September 12, 2024 06:57
@julien-deramond julien-deramond force-pushed the main-jd-fix-typo-for-enable-cssgrid-sass-var branch from 87133f3 to 3f78d65 Compare September 12, 2024 06:57
@julien-deramond julien-deramond mentioned this pull request Sep 18, 2024
Draft
2 tasks
louismaximepiton
louismaximepiton approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we can flag and tackle it for v6 maybe but $enable-css-grid seems better to me.
However, the actual is more consistent with the actual CSS.

@julien-deramond julien-deramond merged commit 2fab352 into main Oct 2, 2024
13 checks passed
@julien-deramond julien-deramond deleted the main-jd-fix-typo-for-enable-cssgrid-sass-var branch October 2, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
docs v5
Projects
v5.3.4
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-deramond @louismaximepiton